Discussion:
threading related pull request for dynamic proxy
Krzysztof Kozmic
2014-06-25 12:28:54 UTC
Permalink
https://github.com/castleproject/Core/pull/60

anyone has any objections against merging this one?

-- 
Krzysztof Kozmic
--
You received this message because you are subscribed to the Google Groups "Castle Project Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-devel+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/***@public.gmane.org
To post to this group, send email to castle-project-devel-/JYPxA39Uh5TLH3MbocFF+G/***@public.gmane.org
Visit this group at http://groups.google.com/group/castle-project-devel.
For more options, visit https://groups.google.com/d/optout.
hammett
2014-06-25 15:19:49 UTC
Permalink
Makes sense. +1

On Wed, Jun 25, 2014 at 9:28 AM, Krzysztof Kozmic
Post by Krzysztof Kozmic
https://github.com/castleproject/Core/pull/60
anyone has any objections against merging this one?
--
Krzysztof Kozmic
--
You received this message because you are subscribed to the Google Groups
"Castle Project Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an
Visit this group at http://groups.google.com/group/castle-project-devel.
For more options, visit https://groups.google.com/d/optout.
--
Cheers,
hammett
http://www.d-collab.com/
http://www.hammettblog.com/
--
You received this message because you are subscribed to the Google Groups "Castle Project Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-devel+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/***@public.gmane.org
To post to this group, send email to castle-project-devel-/JYPxA39Uh5TLH3MbocFF+G/***@public.gmane.org
Visit this group at http://groups.google.com/group/castle-project-devel.
For more options, visit https://groups.google.com/d/optout.
Ken Egozi
2014-06-25 20:56:29 UTC
Permalink
looks legit, +1

Ken Egozi.
http://kenegozi.com/blog
http://aspnetwebstack.codeplex.com
http://www.windowsazure.com/en-us/develop/mobile/
http://www.shopyourway.com
http://www.castleproject.org
Post by hammett
Makes sense. +1
On Wed, Jun 25, 2014 at 9:28 AM, Krzysztof Kozmic
Post by Krzysztof Kozmic
https://github.com/castleproject/Core/pull/60
anyone has any objections against merging this one?
--
Krzysztof Kozmic
--
You received this message because you are subscribed to the Google Groups
"Castle Project Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an
To post to this group, send email to
Visit this group at http://groups.google.com/group/castle-project-devel.
For more options, visit https://groups.google.com/d/optout.
--
Cheers,
hammett
http://www.d-collab.com/
http://www.hammettblog.com/
--
You received this message because you are subscribed to the Google Groups
"Castle Project Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an
.
Visit this group at http://groups.google.com/group/castle-project-devel.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "Castle Project Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-devel+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/***@public.gmane.org
To post to this group, send email to castle-project-devel-/JYPxA39Uh5TLH3MbocFF+G/***@public.gmane.org
Visit this group at http://groups.google.com/group/castle-project-devel.
For more options, visit https://groups.google.com/d/optout.
Ken Egozi
2014-06-25 21:00:53 UTC
Permalink
with a minor comment on the code (extracting the cacheType variable to
outer scope might not be required, though I only looked at the diff, I
might be missing something in the bigger picture)

Ken Egozi.
http://kenegozi.com/blog
http://aspnetwebstack.codeplex.com
http://www.windowsazure.com/en-us/develop/mobile/
http://www.shopyourway.com
http://www.castleproject.org
Post by Ken Egozi
looks legit, +1
Ken Egozi.
http://kenegozi.com/blog
http://aspnetwebstack.codeplex.com
http://www.windowsazure.com/en-us/develop/mobile/
http://www.shopyourway.com
http://www.castleproject.org
Post by hammett
Makes sense. +1
On Wed, Jun 25, 2014 at 9:28 AM, Krzysztof Kozmic
Post by Krzysztof Kozmic
https://github.com/castleproject/Core/pull/60
anyone has any objections against merging this one?
--
Krzysztof Kozmic
--
You received this message because you are subscribed to the Google
Groups
Post by Krzysztof Kozmic
"Castle Project Development List" group.
To unsubscribe from this group and stop receiving emails from it, send
an
Post by Krzysztof Kozmic
To post to this group, send email to
Visit this group at http://groups.google.com/group/castle-project-devel
.
Post by Krzysztof Kozmic
For more options, visit https://groups.google.com/d/optout.
--
Cheers,
hammett
http://www.d-collab.com/
http://www.hammettblog.com/
--
You received this message because you are subscribed to the Google Groups
"Castle Project Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an
To post to this group, send email to
Visit this group at http://groups.google.com/group/castle-project-devel.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "Castle Project Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-devel+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/***@public.gmane.org
To post to this group, send email to castle-project-devel-/JYPxA39Uh5TLH3MbocFF+G/***@public.gmane.org
Visit this group at http://groups.google.com/group/castle-project-devel.
For more options, visit https://groups.google.com/d/optout.
Krzysztof Kozmic
2014-06-26 10:32:22 UTC
Permalink
It got merged, and using our recently added nightly nugget feed I built a non-scientific experiment running this in a console app on my 4 core (HT) MacBook Pro.  It squarely falls into micro optimisation bucket as any performance difference I noticed (ran a few scenarios, with varying number of iterations and proxy types) is almost negligible.

Here’s one such scenario: https://gist.github.com/kkozmic/8362bc57f24d7adf68e2

-- 
Krzysztof Kozmic

From: Ken Egozi egozi13-***@public.gmane.org
Reply: castle-project-devel-/***@public.gmane.org castle-project-***@googlegroups.com
Date: 26 June 2014 at 7:00:57 am
To: Castle Project Development List castle-project-***@googlegroups.com
Subject:  Re: threading related pull request for dynamic proxy

with a minor comment on the code (extracting the cacheType variable to outer scope might not be required, though I only looked at the diff, I might be missing something in the bigger picture)

Ken Egozi.
http://kenegozi.com/blog
http://aspnetwebstack.codeplex.com
http://www.windowsazure.com/en-us/develop/mobile/
http://www.shopyourway.com
http://www.castleproject.org


On Wed, Jun 25, 2014 at 1:56 PM, Ken Egozi <egozi13-***@public.gmane.org> wrote:
looks legit, +1

Ken Egozi.
http://kenegozi.com/blog
http://aspnetwebstack.codeplex.com
http://www.windowsazure.com/en-us/develop/mobile/
http://www.shopyourway.com
http://www.castleproject.org


On Wed, Jun 25, 2014 at 8:19 AM, hammett <hammett-***@public.gmane.org> wrote:
Makes sense. +1

On Wed, Jun 25, 2014 at 9:28 AM, Krzysztof Kozmic
Post by Krzysztof Kozmic
https://github.com/castleproject/Core/pull/60
anyone has any objections against merging this one?
--
Krzysztof Kozmic
--
You received this message because you are subscribed to the Google Groups
"Castle Project Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an
Visit this group at http://groups.google.com/group/castle-project-devel.
For more options, visit https://groups.google.com/d/optout.
--
Cheers,
hammett
http://www.d-collab.com/
http://www.hammettblog.com/

--
You received this message because you are subscribed to the Google Groups "Castle Project Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-devel+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/***@public.gmane.org
To post to this group, send email to castle-project-devel-/JYPxA39Uh5TLH3MbocFF+G/***@public.gmane.org
Visit this group at http://groups.google.com/group/castle-project-devel.
For more options, visit https://groups.google.com/d/optout.


--
You received this message because you are subscribed to the Google Groups "Castle Project Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-devel+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/***@public.gmane.org
To post to this group, send email to castle-project-devel-/JYPxA39Uh5TLH3MbocFF+G/***@public.gmane.org
Visit this group at http://groups.google.com/group/castle-project-devel.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "Castle Project Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-devel+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/***@public.gmane.org
To post to this group, send email to castle-project-devel-/JYPxA39Uh5TLH3MbocFF+G/***@public.gmane.org
Visit this group at http://groups.google.com/group/castle-project-devel.
For more options, visit https://groups.google.com/d/optout.
hammett
2014-06-26 15:11:03 UTC
Permalink
But there's no harm, is there? If there was a downgrade in perf, i'd
be worried (not really)

On Thu, Jun 26, 2014 at 7:32 AM, Krzysztof Kozmic
Post by Krzysztof Kozmic
It got merged, and using our recently added nightly nugget feed I built a
non-scientific experiment running this in a console app on my 4 core (HT)
MacBook Pro. It squarely falls into micro optimisation bucket as any
performance difference I noticed (ran a few scenarios, with varying number
of iterations and proxy types) is almost negligible.
https://gist.github.com/kkozmic/8362bc57f24d7adf68e2
--
Krzysztof Kozmic
Date: 26 June 2014 at 7:00:57 am
Subject: Re: threading related pull request for dynamic proxy
with a minor comment on the code (extracting the cacheType variable to outer
scope might not be required, though I only looked at the diff, I might be
missing something in the bigger picture)
Ken Egozi.
http://kenegozi.com/blog
http://aspnetwebstack.codeplex.com
http://www.windowsazure.com/en-us/develop/mobile/
http://www.shopyourway.com
http://www.castleproject.org
Post by Ken Egozi
looks legit, +1
Ken Egozi.
http://kenegozi.com/blog
http://aspnetwebstack.codeplex.com
http://www.windowsazure.com/en-us/develop/mobile/
http://www.shopyourway.com
http://www.castleproject.org
Post by hammett
Makes sense. +1
On Wed, Jun 25, 2014 at 9:28 AM, Krzysztof Kozmic
Post by Krzysztof Kozmic
https://github.com/castleproject/Core/pull/60
anyone has any objections against merging this one?
--
Krzysztof Kozmic
--
You received this message because you are subscribed to the Google Groups
"Castle Project Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an
To post to this group, send email to
Visit this group at
http://groups.google.com/group/castle-project-devel.
For more options, visit https://groups.google.com/d/optout.
--
Cheers,
hammett
http://www.d-collab.com/
http://www.hammettblog.com/
--
You received this message because you are subscribed to the Google Groups
"Castle Project Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an
To post to this group, send email to
Visit this group at http://groups.google.com/group/castle-project-devel.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
"Castle Project Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an
Visit this group at http://groups.google.com/group/castle-project-devel.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
"Castle Project Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an
Visit this group at http://groups.google.com/group/castle-project-devel.
For more options, visit https://groups.google.com/d/optout.
--
Cheers,
hammett
http://www.d-collab.com/
http://www.hammettblog.com/
--
You received this message because you are subscribed to the Google Groups "Castle Project Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-devel+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/***@public.gmane.org
To post to this group, send email to castle-project-devel-/JYPxA39Uh5TLH3MbocFF+G/***@public.gmane.org
Visit this group at http://groups.google.com/group/castle-project-devel.
For more options, visit https://groups.google.com/d/optout.
Ken Egozi
2014-06-26 14:01:41 UTC
Permalink
Might be a silly change but what if you switch the for loops?

Sent from my Windows Phone
------------------------------
From: Krzysztof Kozmic <krzysztof.kozmic-***@public.gmane.org>
Sent: ‎6/‎26/‎2014 3:32 AM
To: castle-project-devel-/***@public.gmane.org
Subject: Re: threading related pull request for dynamic proxy

It got merged, and using our recently added nightly nugget feed I built a
non-scientific experiment running this in a console app on my 4 core (HT)
MacBook Pro. It squarely falls into micro optimisation bucket as any
performance difference I noticed (ran a few scenarios, with varying number
of iterations and proxy types) is almost negligible.

Here’s one such scenario:
https://gist.github.com/kkozmic/8362bc57f24d7adf68e2
--
Krzysztof Kozmic

From: Ken Egozi egozi13-***@public.gmane.org
Reply: castle-project-devel-/***@public.gmane.org
castle-project-devel-/***@public.gmane.org
Date: 26 June 2014 at 7:00:57 am
To: Castle Project Development List castle-project-devel-/***@public.gmane.org
Subject: Re: threading related pull request for dynamic proxy

with a minor comment on the code (extracting the cacheType variable to
outer scope might not be required, though I only looked at the diff, I
might be missing something in the bigger picture)

Ken Egozi.
http://kenegozi.com/blog
http://aspnetwebstack.codeplex.com
http://www.windowsazure.com/en-us/develop/mobile/
http://www.shopyourway.com
http://www.castleproject.org
Post by Ken Egozi
looks legit, +1
Ken Egozi.
http://kenegozi.com/blog
http://aspnetwebstack.codeplex.com
http://www.windowsazure.com/en-us/develop/mobile/
http://www.shopyourway.com
http://www.castleproject.org
Post by hammett
Makes sense. +1
On Wed, Jun 25, 2014 at 9:28 AM, Krzysztof Kozmic
Post by Krzysztof Kozmic
https://github.com/castleproject/Core/pull/60
anyone has any objections against merging this one?
--
Krzysztof Kozmic
--
You received this message because you are subscribed to the Google
Groups
Post by Krzysztof Kozmic
"Castle Project Development List" group.
To unsubscribe from this group and stop receiving emails from it, send
an
Post by Krzysztof Kozmic
To post to this group, send email to
Visit this group at http://groups.google.com/group/castle-project-devel
.
Post by Krzysztof Kozmic
For more options, visit https://groups.google.com/d/optout.
--
Cheers,
hammett
http://www.d-collab.com/
http://www.hammettblog.com/
--
You received this message because you are subscribed to the Google Groups
"Castle Project Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an
To post to this group, send email to
Visit this group at http://groups.google.com/group/castle-project-devel.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
"Castle Project Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to castle-project-devel+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/***@public.gmane.org
To post to this group, send email to castle-project-devel-/JYPxA39Uh5TLH3MbocFF+G/***@public.gmane.org
Visit this group at http://groups.google.com/group/castle-project-devel.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups
"Castle Project Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to castle-project-devel+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/***@public.gmane.org
To post to this group, send email to castle-project-devel-/JYPxA39Uh5TLH3MbocFF+G/***@public.gmane.org
Visit this group at http://groups.google.com/group/castle-project-devel.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "Castle Project Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an email to castle-project-devel+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/***@public.gmane.org
To post to this group, send email to castle-project-devel-/JYPxA39Uh5TLH3MbocFF+G/***@public.gmane.org
Visit this group at http://groups.google.com/group/castle-project-devel.
For more options, visit https://groups.google.com/d/optout.
Loading...